The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @wclear.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: wclear.

Co-authored-by: Infinite-Null <ankitkumarshah@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: paaljoachim <paaljoachim@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
Co-authored-by: amustaque97 <amustaque97@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>
Co-authored-by: zaguiini <zaguiini@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

This looks like based on the video is working well!
Nicely done.

I think we're moving in the right direction, but PR still needs some work.

Notes

• a11y. Let's ensure we're not introducing accessibility regression. After this change, the user can't navigate away from the code block using Tab.
• This should allow indenting the selected text, including multi-line selection. Currently, it just deletes the selection.
• The Shift+Tab is comment shortcut for outdenting the selection. Not a blocker, but it would also be a good addition.
• Evaluate and check if we can use existing rich-text helpers. Working with RichText can be complex; let's try to use existing tools when possible. I'm not an expert in this field, so maybe @ellatrix can give us some pointers.

I think we can resolve the first point by only allowing indent/outdent when there's a text selection. This is how GitHub handles similar logic in the comment textarea.

Screeencast

Hi @Mamaduka,
Thank you for the feedback 🙌! I have updated the logic to make it similar to GitHub's textarea tab indentation.
Please review it at your convenience.

Hi @Mamaduka,
I have also added the shift + tab to outdend the code. Please review it at your convenience:

Thanks for the follow-ups, @Infinite-Null!

I'll try to test this properly later today. Meanwhile, here are some general notes:

• Let's update the PR title and description. We're not fixing the focus loss here, but instead introducing an enhancement for the Code block.
• The indentation hook logic can be moved outside of the component, in the same file as a custom hook - useTab or something like that.
• Use early returns when possible to reduce nesting and make code more readable.

Hi @Mamaduka, Thank you for the feedback. I have moved the logic to the useTabIndentation custom hook and also added early returns. Please review it at your convenience.