Skip to content

Accordion Blocks: Organize block supports #71823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
t-hamano merged 2 commits into from
Sep 23, 2025
Merged

Accordion Blocks: Organize block supports #71823

t-hamano merged 2 commits into from
Sep 23, 2025

Conversation

@ritoban23
Copy link
Contributor

@ritoban23 ritoban23 commented Sep 22, 2025

What?

Closes #71801

This PR organizes block supports for the Accordion block family by adding typography and removing conflicting margin settings.

Why?

  1. Missing typography controls in core/accordion and core/accordion-content.
  2. margin support from core/accordion-header and core/accordion-panel conflicts with the parent block's gap settings.

How?

updated the supports object in the block.json files for the four accordion blocks to add typography and remove margin where appropriate, following the patterns used by other core blocks.

@github-actions
Copy link

github-actions bot commented Sep 22, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ritoban23 <devrito@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Sep 22, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ritoban23! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 22, 2025
@shail-mehta shail-mehta added [Block] Accordion Affects the Accordion Block [Type] Enhancement A suggestion for improvement. labels Sep 22, 2025
@shail-mehta
Copy link
Member

shail-mehta commented Sep 22, 2025

@ritoban23 Thanks for the PR.

Could you please resolve the conflicts and rebase this branch onto the latest trunk?

@ritoban23 ritoban23 force-pushed the feature/organize-accordion-block-supports-71801 branch from 0005c33 to 5648795 Compare September 22, 2025 16:40
shail-mehta
shail-mehta reviewed Sep 22, 2025
View reviewed changes
Copy link
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritoban23 Can you please Run npm run docs:build in your local repo for document update?

t-hamano
t-hamano approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Sep 23, 2025
@t-hamano t-hamano merged commit db69b76 into WordPress:trunk Sep 23, 2025
78 of 84 checks passed
@t-hamano t-hamano removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Sep 23, 2025
@t-hamano t-hamano mentioned this pull request Sep 20, 2025
Closed
9 tasks
@github-actions github-actions bot added this to the Gutenberg 21.8 milestone Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shail-mehta shail-mehta shail-mehta left review comments

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

Assignees

No one assigned

Labels

[Block] Accordion Affects the Accordion Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 21.8

Development

Successfully merging this pull request may close these issues.

Accordion Blocks: Organize block supports

3 participants

@ritoban23 @shail-mehta @t-hamano