Tests: Add PHPUnit tests for REST API classes #332
Merged
+2,831
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #332 +/- ##
============================================
+ Coverage 22.86% 23.67% +0.80%
Complexity 4410 4410
============================================
Files 291 291
Lines 36940 36940
============================================
+ Hits 8448 8745 +297
+ Misses 28492 28195 -297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9dd3270 to
8d7fe26
Compare
22 tasks
cf04582 to
43e3104
Compare
Add comprehensive tests for the REST API integration: - test-acf-rest-api.php: Tests for ACF_Rest_Api class including initialization, schema generation, field loading, and filtering - test-acf-rest-api-functions.php: Tests for helper functions like acf_get_field_rest_schema() and acf_format_value_for_rest() - test-acf-rest-embed-links.php: Tests for ACF_Rest_Embed_Links class covering link preparation and response integration - test-acf-rest-request.php: Tests for ACF_Rest_Request class including request parsing and URL parameter handling Test coverage includes: - REST API initialization and configuration - Schema generation and structure validation - Field loading with show_in_rest filtering - Request parsing and object type detection - Embed link preparation and loading - Filter hook integration (acf/rest/* hooks) - Admin mode detection - REST API format settings (light/standard) - Error handling and edge cases 143 tests with 200 assertions. Some tests are skipped in WorDBless environment due to field type and location type registration limitations.
43e3104 to
707c905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #315.
Adds PHPUnit test coverage for the REST API integration classes and helper functions.
Why
The REST API integration is critical for exposing SCF field data through WordPress REST endpoints. It handles:
show_in_restHow
Adding 134 tests across 4 test files:
ACF_Rest_Apiclass: initialization, hooks, schema generation, field loading, filtering byshow_in_rest, location matching, admin mode detection, REST format settingsACF_Rest_Requestclass: request parsing, URL parameter handling (_fields,_embed), object type detection, route matching, HTTP method detectionACF_Rest_Embed_Linksclass: link preparation, response integration, field link building, hook registrationacf_get_field_rest_schema()schema generation with filter hooks,acf_format_value_for_rest()value formatting,acf_get_field_rest_links()link generation, filter variations by type/name/keyTesting Instructions
./vendor/bin/phpunit --filter "Test_ACF_Rest"