Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

@up1512001
Copy link
Member

fixes #323

Description

  • created a hidden pattern for the heading of the home & index template.
  • added i18n to the Blog text.
  • replace the core/heading block of the home & index template with the hidden pattern.

Screenshots

Screen.Recording.2024-09-16.at.23.59.23.mov

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <up1512001@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

The PHP file needs to end with a single empty line.
Can we use a shorter name and slug? Why not just use hidden-blog-heading ?

This makes both headings left aligned, but from the recording, this does not seem to cause any issues.

@up1512001
Copy link
Member Author

@carolinan updated file name & slug as per your suggestion.

@up1512001
Copy link
Member Author

This makes both headings left aligned, but from the recording, this does not seem to cause any issues.

@carolinan Yes, aligning the heading to the left for index.html is not causing any issues.

Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this :)

@carolinan carolinan merged commit 1786773 into WordPress:trunk Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Translatable text in the HTML files must be turned into patterns

2 participants