Replace fixed elements with a placeholder #400
Conversation
This solves the issue where this template was showing multiple "No posts were found." messages. By using the placeholder we can show this message only in the editor and avoid displaying it on the front end.
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Question: what is the benefit of keeping the blocks with the placeholders in the editor? I think it is best to keep the message on the first query visible on the front. 🤔 Otherwise the page will say "...these are some..." and then there is nothing, without an explanation. |
|
IMHO the benefit is that the users are made aware that there's a position there to insert content. |
|
@eliorivero Thank you for working on this. Since there is no consensus on if these should be changed or not, and because the time until the release is short, I am going to close this PR. |
Description
This solves the issue where the Portfolio Homepage template was showing multiple "No posts were found." messages. By using the placeholder we can show this message only in the editor and avoid displaying it on the front end.
Screenshots
Used two languages, Spanish and German, to better highlight what's text produced by WordPress (the localized text) and which one was the fixed text from the pattern (text in English).
Previously, the editor was showing multiple "No posts were found."
Which were also visible on the front end
With this approach, the messages are shown as placeholders in the editor
and the messages aren't visible on the front end
Testing Instructions