-
Notifications
You must be signed in to change notification settings - Fork 127
A11y fix: adds a checkmark block style for lists and replaces it in home.php
#150
Conversation
|
Do we not need a separate block pattern for this? |
|
@carolinan It's a change in two existing block patterns If we wanted to offer an easy to use checkmark list, a block variation might be a better fit perhaps? |
|
I don't see any updates made to left-aligned-cta-image.php? |
|
@carolinan Ooh, that's right, my bad. The original Here's what
Here's what it could look like with the checkmarks style: Should we get design feedback on this? |
|
I found the pattern in Figma, and it has checkmarks: |
|
Thanks for linking to the pattern in the design file directly, @carolinan. Much appreciated. The pattern has been updated, and I also overall tweaked the styling of checkmark lists globally so they better match the design:
|
|
Noting that we need to incorporate an RTL solution as well as per the slack conversation today with @MaggieCabrera |
|
the pattern Features with Images also needs the same implementation |
|
#292 is working on adding some design adjustments after the pattern was reviewed. The markup provided in the adjustment turns the list into a paragraph block, which is not what we want, but it's the look we are aiming for. Let's keep the spacing, line height and layout from those adjustments when we make changes to the markup here. |
|
I tried rebasing, had a hard time, figured it was better to just start over. Closing in favor of #369, let's continue there, but I basically picked up the changes from here and moved them to trunk manually with a couple of tweaks |
* adds changes from #150 * Checkmarks -> Checkmark --------- Co-authored-by: Rich Tabor <hi@richtabor.com>



Closes #46.
Description
Right now there's a list pattern used in the home template for TT4 that uses paragraphs with checkmarks to simulate a list. This is an accessibility issue as described in #46:
This PR registers a new custom block style for Lists called
Checkmarksto fix that issue.Screenshots
Desktop view:
Mobile view:

Design discussion/question:
Testing Instructions