Add valid preferred_ext check in wp_mime_type_icon and unit testcase … #6592
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
joedolson
left a comment
There was a problem hiding this comment.
Minor changes requested; but this looks good, overall.
src/wp-includes/post.php
Outdated
| $icon = wp_cache_get( "mime_type_icon_$mime" ); | ||
| } | ||
|
|
||
| // Check preferred file format is available and if it is begins with a period or not. |
There was a problem hiding this comment.
I think this is a better comment:
// Check if preferred file format variable is present and is a valid file extension.
There was a problem hiding this comment.
Maybe more like "validly formatted file extension", since we're not actually checking the extension validity.
joedolson
left a comment
There was a problem hiding this comment.
One minor change that I'll make at commit.
|
In r58248 |
…for it
Add
$preferred_extcheck in functionwp_mime_type_iconwith proper unit test cases.Trac ticket: #60610
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.