-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update theme.js #6976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme.js #6976
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sabernhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me in testing, but you could remove the comments and edit some spacing and indentation.
Removed comments Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Removed spaces Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Added spaces Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
|
All suggested changes are applied, thank you :) |
|
This tests well for me on 6.6.1. Thanks for working on a fix! |
|
Awesome, Thank you! |
hellofromtonya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested for issues with Appearance > Themes and Appearance > Themes > Add Theme.
✅ This patch resolves the issues with both search workflows.
LGTM for commit.
|
Committed via https://core.trac.wordpress.org/changeset/58914. |
Ticket - https://core.trac.wordpress.org/ticket/61578