Skip to content

Conversation

@ankur0007
Copy link

@github-actions
Copy link

github-actions bot commented Jul 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props the-ank, debarghyabanerjee, sabernhardt, jeherve.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jul 5, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@sabernhardt sabernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me in testing, but you could remove the comments and edit some spacing and indentation.

ankur0007 and others added 3 commits July 18, 2024 19:16
Removed comments

Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Removed spaces

Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
Added spaces

Co-authored-by: Stephen A. Bernhardt <sabernhardt@yahoo.com>
@ankur0007
Copy link
Author

All suggested changes are applied, thank you :)

@jeherve
Copy link

jeherve commented Jul 24, 2024

This tests well for me on 6.6.1. Thanks for working on a fix!

@ankur0007
Copy link
Author

Awesome, Thank you!

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for issues with Appearance > Themes and Appearance > Themes > Add Theme.

✅ This patch resolves the issues with both search workflows.

LGTM for commit.

@hellofromtonya
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants