HTML API: Recognize all uppercase tag names in tag processor #7897
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SantosGuillamot
left a comment
There was a problem hiding this comment.
From my tests, this solves the original issue, and it looks like the right solution 👏
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Committed in https://core.trac.wordpress.org/changeset/59464 |
Ensure uppercase tag names are matched correctly by the tag processor.
Ticket 62522 describes an issue where a whitespace-prefixed tag was causing problems. With the help of @SantosGuillamot and @cbravobernal, this was narrowed down to an uppercase open tag name preceded by whitespace not being recognized by the tag processor.
There was a missing "D" in the character list used by
strspnto find tag openers, causing tags starting withDto be skipped by the tag processor in some circumstances.This only appears in rare cases because the tag name must appear in the correct position (preceded by whitespace) and must start with an uppercase
D. Casing is not relevant for tag names, and most tag names are lowercase in the wild.Trac ticket: https://core.trac.wordpress.org/ticket/62522
Follow up [58613]
Closes #7893 (supersedes).
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.