-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Open settings submenu links in new tabs #9130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Open settings submenu links in new tabs #9130
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi @vidushigupta0607! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The account has been linked now! |
30bf468 to
9190dcf
Compare
| printf( | ||
| /* translators: %s: Documentation URL. */ | ||
| __( 'Enter the same address here unless you <a href="%s">want your site home page to be different from your WordPress installation directory</a>.' ), | ||
| __( 'Enter the same address here unless you <a href="%s" target=_blank>want your site home page to be different from your WordPress installation directory</a>.' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| __( 'Enter the same address here unless you <a href="%s" target=_blank>want your site home page to be different from your WordPress installation directory</a>.' ), | |
| __( 'Enter the same address here unless you <a href="%s" target="_blank">want your site home page to be different from your WordPress installation directory</a>.' ), |
Problem
Several external links within WordPress admin setting pages—specifically General, Discussion, and Permalink—currently open in the same window. This behavior can negatively impact the user experience in the following ways:
Users may lose unsaved changes if they click an external link without first saving their settings.
Users may assume the link opens in a new tab (as is the case with links in the Edit Profile page or the Help tab), and unintentionally navigate away from the page.
Inconsistencies in link behavior across admin pages create confusion and a fragmented user experience.
Root Cause
Some documentation/help links in the admin settings screens do not include target="_blank". This leads to an inconsistent user interface where users cannot predict link behavior.
Solution
Update external documentation/help links in affected settings pages to:
This aligns their behavior with other similar links in the admin UI, prevents data loss from navigation, and improves overall consistency and UX.
Trac ticket: https://core.trac.wordpress.org/ticket/23432