Skip to content

Update Lerna from 6.6.2 to 7.1.3 in order to run Release NPM packages Github Action #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamziel merged 1 commit into from
Dec 15, 2025
Merged

Update Lerna from 6.6.2 to 7.1.3 in order to run Release NPM packages Github Action #3038

adamziel merged 1 commit into from
Dec 15, 2025

Conversation

@mho22
Copy link
Collaborator

@mho22 mho22 commented Dec 15, 2025

Motivation for the change, related issues

I noticed NPM packages were not updated since 4 weeks due to a lerna Err:

lerna ERR! TypeError: resolvedPrettier.resolveConfig.sync is not a function
lerna ERR!     at maybeFormatFile (/home/runner/work/wordpress-playground/wordpress-playground/node_modules/lerna/dist/cli.js:5776:53)
lerna ERR!     at gitAdd (/home/runner/work/wordpress-playground/wordpress-playground/node_modules/lerna/dist/cli.js:5799:9)
lerna ERR!     at /home/runner/work/wordpress-playground/wordpress-playground/node_modules/lerna/dist/cli.js:6622:36
lerna ERR!     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
lerna ERR!     at async Promise.all (index 0)

I found this issue and this issue on the lerna github repository where it was mentionned that version 7.1.3 of lerna fixed the above issue.

Implementation details

Updating lerna version in github actions and in package.json

Testing Instructions (or ideally a Blueprint)

CI - Release NPM packages - should pass.

@mho22 mho22 requested a review from a team as a code owner December 15, 2025 14:46
@mho22 mho22 added [Type] Bug An existing feature does not function as intended [Feature] GitHub integration dependencies Pull requests that update a dependency file labels Dec 15, 2025
@adamziel
Copy link
Collaborator

adamziel commented Dec 15, 2025

Oh no, a Lerna update. these are notoriously painful fingers crossed this one goes easily (although I already see a test failed in a weird way). I wonder if there's any tool that we could use instead of lerna for publishing packages.

@mho22
Copy link
Collaborator Author

mho22 commented Dec 15, 2025

@adamziel I re-ran the failed tests and they passed! I don't know if this is enough to merge the pull request but it looks like I had luck about this lerna update.

The Release NPM packages github action should also be triggered manually I think.

@adamziel adamziel merged commit 1c8adda into trunk Dec 15, 2025
63 of 65 checks passed
@adamziel adamziel deleted the update-lerna-to-7-1-3 branch December 15, 2025 15:47
@adamziel
Copy link
Collaborator

adamziel commented Dec 15, 2025

It seems like we're lucky today, then. yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file [Feature] GitHub integration [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mho22 @adamziel