[CI] Extract npm package integration tests to reusable scripts #3078
+259
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hm, I expected this to fail, something's off |
72979f2 to
5446f68
Compare
The npm integration tests used to only install @wp-playground/cli from the local package server, with the URL hardcoded in the workflow. This change makes the local registry work for all @wp-playground/* and @php-wasm/* packages. Now any playground package added to test project dependencies will automatically be fetched from the local registry. The jq script rewrites package URLs at runtime based on the package name pattern. Also fixes a bug where VERSION was set twice with different timestamps - once for the URL and once for updating package.json files.
5446f68 to
25a46fc
Compare
Collaborator
Author
|
Aha, I thought the built CJS packages are broken based on #3072 but they're not, at least I couldn't find any way to reproduce that error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the npm package integration test logic from inline CI steps into reusable bash scripts that work both in CI and locally on Mac.
The scripts build all packages, start a local HTTP server to serve them, rewrite test project dependencies to use the local registry, and run the integration tests.
New scripts:
packages/playground/test-built-npm-packages/run-tests.sh- Main entry pointpackages/playground/test-built-npm-packages/use-local-packages.sh- Rewrites package.json dependenciesrun-with-local-packages.shscripts in each test projectLocal usage:
Also fixes a bug where
VERSIONwas set twice with different timestamps.Test plan
test-built-npm-packagesjob