Skip to content

Conversation

@leonidasmi
Copy link
Contributor

@leonidasmi leonidasmi commented Dec 11, 2025

Context

Summary

This PR can be summarized in the following changelog entry:

  • Rolls out the Site Kit integration for all Yoast users.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

In a fresh site that has not Site Kit already or the feature flag enabled from the Yoast test helper, smoke test the following parts of the Site Kit integration:

  • First confirm that the value of the wpseo option array has the site_kit_configuration_permanently_dismissed sub-setting as 0 and then do the following POST request: https://example.com/wp-json/yoast/v1/site_kit_configuration_permanent_dismissal
    • Set the request body as follows { "is_dismissed": true }
    • Verify you get a successful response
    • With a MySQL inspect the value of the wpseo option array in the wp_options table
      • Verify that site_kit_configuration_permanently_dismissed is set to 1
    • Reset options after that
  • Now start the onboarding flow and once you setup Site Kit , make sure you are redirected to our dashboard and greeted by this alert:
image
  • Before giving consent as the last step of the onboarding, check your wpseo option and confirm that you see the last_interaction_stage sub-setting have the grantConsent value
  • Give consent as the last step of the onboarding and open a new tab. Confirm that you see the site kit widgets working.
  • In the Yoast dashboard page, type wpseoScriptData.dashboard.browserCache in the console. Confirm that it's the same with and without this PR/RC
  • In the Yoast dashboard page, type wpseoScriptData.dashboard.siteKitConfiguration in the console. Confirm that it's the same with and without this PR/RC
  • Make sure you have a user with SEO manager role
    • Let the admin user give the SEO manager viewing capabilities in the Google Site Kit plugin
    • Visit the Yoast Dashboard as a SEO manager and confirm that you see the widgets you're supposed to see
    • Revoke viewing capabilities from SEO managers
    • As a SEO manager, open a new tab and visit the Yoast Dashboard again. Confirm that you dont see data in the widgets anymore but rather a helpful message:
image

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • The Site Kit integration in general, some smoke testing has been already included in the test instructions.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have ran grunt build:images and commited the results, if my PR introduces new images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@leonidasmi leonidasmi added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Dec 11, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build fbdccd566474bbda3e07cf88b2a9d4200114c85c

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 52.524%

Totals Coverage Status
Change from base Build bf24bec1e45770deae5b68bf87e981a3db8b213c: -0.001%
Covered Lines: 31826
Relevant Lines: 60803

💛 - Coveralls

@leonidasmi leonidasmi changed the title Deprecate site kit feature flag conditional Roll out the Site Kit integration for all Yoast users Dec 11, 2025
@leonidasmi leonidasmi marked this pull request as ready for review December 11, 2025 11:40
Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@thijsoo thijsoo added this to the 26.7 milestone Dec 11, 2025
@thijsoo thijsoo merged commit b3f2acf into trunk Dec 11, 2025
32 checks passed
@thijsoo thijsoo deleted the 924-enable-site-kit-for-all-free-users branch December 11, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants