VTT parsing - Allow hour section that isn't 2 digits #645
Conversation
- Allow more than 2 digits for extremely long videos - Although the spec says it must be 2+ and so single digit times (e.g. 1:02:24.000 --> 1:04:48.000) are invalid, allow these too as it's unambiguous what was intended and easy to handle
|
Thanks for the PR! Would you be able to re-base this against the develop branch? (See the contributing guidelines) |
|
Sorry, my mistake, rebased |
|
Thank you! |
|
I'm inclined to go ahead and do this, although I'm still a little on the fence. I read all of the W3C spec conversations about timestamp syntax, and it's not an issue that they ever addressed - but they extensively discussed the issue for milliseconds, and one of the arguments against allowing that spec to be flexible was to discourage support of non-conforming VTT generation tools. That said, I think you're right that although there is some ambiguity in milliseconds, there isn't any in the hours, and there's really no functional difference between |
Timestamps like this are the cause of a real customer supported issue for us, so while it would be fair to tell them to fix their VTT generation, it would be good to be able to parse and allow them.