-
Notifications
You must be signed in to change notification settings - Fork 230
Merge main into gh-pages #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main back into develop.
YouTube source can either be on a `source` element or on the `video` element, because the cases of "local with remote sign" requires `source` but `youtube with remote sign` only requires `video`.
Fixes #674 Also switches all 'em' units to 'rem' units for consistency.
The old shadow provided player boundaries if the poster image matched the background. This is an alternate way that's less invasive.
fix for regex in the postprocessCTag function
Also: missing argument for captions button state. See #678
…e refreshed unless the player is refreshed. This was causing the button state to get reversed repeatedly. See #678 (related issue.)
This worked because the selector returned an empty jQuery collection, so it was *always* running. With this change, it should only run one popups are visible.
If the 'play' event fires and 'playing' doesn't, that means that playback has failed, so there is no actual state change. We could conceivably initiate an error state here, cleared in playing.
All this does is calculate the absdiff between these two static numbers, then never use the result. Based on similarity, this may have been debugging related to checking whether durations are close enough.
Merge Develop into Main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.