Skip to content

Conversation

@joedolson
Copy link
Contributor

No description provided.

joedolson and others added 30 commits August 11, 2025 17:38
Merge main back into develop.
YouTube source can either be on a `source` element or on the `video` element, because the cases of "local with remote sign" requires `source` but `youtube with remote sign` only requires `video`.
Fixes #674

Also switches all 'em' units to 'rem' units for consistency.
The old shadow provided player boundaries if the poster image matched the background. This is an alternate way that's less invasive.
fix for regex in the postprocessCTag function
Also: missing argument for captions button state.

See #678
…e refreshed unless the player is refreshed.

This was causing the button state to get reversed repeatedly.

See #678 (related issue.)
This worked because the selector returned an empty jQuery collection, so it was *always* running. With this change, it should only run one popups are visible.
If the 'play' event fires and 'playing' doesn't, that means that playback has failed, so there is no actual state change.

We could conceivably initiate an error state here, cleared in playing.
All this does is calculate the absdiff between these two static numbers, then never use the result.

Based on similarity, this may have been debugging related to checking whether durations are close enough.
@joedolson joedolson merged commit c3e0c12 into gh-pages Sep 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants