Skip to content

Conversation

@joedolson
Copy link
Contributor

Merges development for 4.8 into the main branch.

These get sanitized by DOMPurify, we need to put them back
…webvtt-unsanitize

#692 Parse timestamp tags in WebVTT
With this change, translations do not *depend* on translations being present, and while missing translations with log console errors, they will not error out the player. Fixes #682.

Also helps with maintenance and translation, as the actual text is available when manipulating code.
This was only here to patch in missing support for `aria-label`, and is overriden by that. Fixes #659.
Requires a switch from array to object data for langs, to provide language names.
See #680. The script-defined sizes make responsive handling more difficult. Modern CSS does a better job here.
Default design is a left-aligned small image. Other styles would have to be custom. Fixes #555
If window is offscreen left, set to position 0. If it's offscreen right, align right edge of window to right edge of viewport.

Behaves slightly differently on left than right; the goal is to keep the options toggle visible.

Fixes #657
This violates the YouTube branding guidelines, so I'm just committing it so that I can pull the relevant characteristics out in one commit.
Due to violation of brand guidelines.
This causes the player to exit fullscreen when a playlist moves to the next item. I'm unable to see a reason to force this exit when redrawing the player; not doing it just maintains the current state, which I think is desirable.

Fixes #681
Removes five arguments from the AccessibleDialog: dialogRole (all Able Player dialogs have the dialog role), isModal (all Able Player's dialogs are modal), $descDiv, unused; width; replaced with CSS; escapeHook - only used by fullscreen, which is already know from the 'fullscreen' arg.

This allows width to be fully controlled in CSS; also changes default width to `fit-content`.

Also removes the polyfill of fullscreen mode. This was only used by iOS, but it really hasn't worked in years. Better to remove it than to have a broken feature.

See #493, #48.
Ensures that sign and transcript remain visible and movable.

fixes #714
@joedolson joedolson merged commit ebc1f30 into main Jan 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants