Merged
Conversation
Jym77
approved these changes
Sep 15, 2023
carlosapaduarte
requested changes
Sep 15, 2023
Member
carlosapaduarte
left a comment
There was a problem hiding this comment.
Some trailing slashes left behind
Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>
carlosapaduarte
approved these changes
Sep 15, 2023
daniel-montalvo
approved these changes
Oct 13, 2023
Jym77
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Stop linking to proposed rules * Apply suggestions from code review Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt> --------- Co-authored-by: Carlos Duarte <caduarte@campus.ul.pt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have redirects set up now, if the rule isn't approved yet, we don't need to link to proposed rules anymore.
Need for Call for Review: none, editorial stuff
How to Review And Approve