[chore] Text spacing: Remove old versions of the rules#2134
Merged
Conversation
WilcoFiers
approved these changes
Nov 6, 2023
giacomo-petri
approved these changes
Nov 6, 2023
carlosapaduarte
approved these changes
Nov 6, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1923 I messed up by:
idof the other two new rules without deleting the older version 🙈This results in two rules having the same
id, which totally messes up the toolchain downstream (and rightfully so). This PR fixes that by totally removing the old rules.Closes issue(s):
Need for Call for Review:
This will not require a Call for Review (correcting a messed up problem)
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve