Skip to content

[chore] Text spacing: Remove old versions of the rules#2134

Merged
Jym77 merged 1 commit intodevelopfrom
text-spacing-cleanup
Nov 6, 2023
Merged

[chore] Text spacing: Remove old versions of the rules#2134
Jym77 merged 1 commit intodevelopfrom
text-spacing-cleanup

Conversation

@Jym77
Copy link
Collaborator

@Jym77 Jym77 commented Nov 6, 2023

In #1923 I messed up by:

  • creating new rules and deprecating the old ones;
  • after Text spacing rewrite #1923 (comment), decided to instead replace the old ones by the newer version;
  • do the correct swap for one of the rule;
  • change the id of the other two new rules without deleting the older version 🙈

This results in two rules having the same id, which totally messes up the toolchain downstream (and rightfully so). This PR fixes that by totally removing the old rules.

Closes issue(s):

  • N/A

Need for Call for Review:
This will not require a Call for Review (correcting a messed up problem)


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@Jym77 Jym77 merged commit c6e0be9 into develop Nov 6, 2023
@Jym77 Jym77 deleted the text-spacing-cleanup branch November 6, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants