Conversation
89f46f0 to
02492e1
Compare
0ccd6d3 to
d2cd4f8
Compare
Member
|
@anonrig Just to confirm... is this the spec? https://urlpattern.spec.whatwg.org |
Member
Author
Yes that's correct @lemire |
e51503f to
524cb73
Compare
jasnell
reviewed
Dec 4, 2024
jasnell
reviewed
Dec 4, 2024
jasnell
reviewed
Dec 4, 2024
1a98cc9 to
18ef1a6
Compare
Member
|
I don't particular mind, but please be aware that you are changing the coding convention. The C++ standard library uses all-lowercase with underscores names. You are using Camel case. If you merge this, it will mean that within the same library, we mix two conventions. |
380d57e to
880e260
Compare
51690eb to
010bc69
Compare
Member
Author
010bc69 to
a036101
Compare
Member
|
Definitely on my todo!!!! |
Contributor
|
Looking good so far. I think I'll need tests in place to properly evaluate everything go given the complexity. I want to be able to build and test locally with it before signing off. |
65c0406 to
61728b2
Compare
Member
Author
|
@jasnell This is ready to land. Would you be interested in writing the C API? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements URLPattern from scratch. I'm adding
TODO: Optimization opportunitynotes in places I think an optimization can be done. The goal is to merge this once there is noTODO: Implement thiscomments.TODOs
TODO: Implement thisoccurrences (currently 4)url_pattern::matchFixes #679