Skip to content

Fix integration for Allure and pytest_bdd when test parameter is dict #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elchupanebrej wants to merge 2 commits into from
Closed

Fix integration for Allure and pytest_bdd when test parameter is dict #660

elchupanebrej wants to merge 2 commits into from

Conversation

@elchupanebrej
Copy link

@elchupanebrej elchupanebrej commented May 10, 2022 •
edited
Loading

Context

When do allure serve on the next generated report
https://gist.github.com/elchupanebrej/4b1d78096ac181ef56edd9b1a1549f57

Allure fails:
https://gist.github.com/elchupanebrej/e753d7d1005c811ff616417ae625df51

This happens because of dangerous serialization at

data = asdict(item, filter=lambda attr, value: not (type(value) != bool and not bool(value)))

Checklist

@CLAassistant
Copy link

CLAassistant commented May 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@elchupanebrej elchupanebrej marked this pull request as ready for review May 10, 2022 18:36
@elchupanebrej elchupanebrej force-pushed the fix_failing_reports_serving branch 5 times, most recently from 1f8863b to eed996b Compare May 12, 2022 14:45
@elchupanebrej elchupanebrej mentioned this pull request May 13, 2022
Closed
@elchupanebrej elchupanebrej reopened this Jul 24, 2022
@elchupanebrej elchupanebrej force-pushed the fix_failing_reports_serving branch 5 times, most recently from 5ca2f22 to 1be6e47 Compare July 24, 2022 09:33
@elchupanebrej
Copy link
Author

elchupanebrej commented Jul 24, 2022

@sseliverstov please review

@elchupanebrej elchupanebrej force-pushed the fix_failing_reports_serving branch from ae969ae to e903ea6 Compare August 4, 2022 14:01
@elchupanebrej elchupanebrej mentioned this pull request Aug 4, 2022
Open
@elchupanebrej elchupanebrej force-pushed the fix_failing_reports_serving branch from e903ea6 to bf8c17d Compare August 11, 2022 15:35
@delatrie
Copy link
Contributor

delatrie commented Mar 27, 2025

Scenario outline params now are always strings.
As for pytest params and step args, #845 adds a proper conversion to strings for them.

@delatrie delatrie closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

theme:pytest-bdd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elchupanebrej @CLAassistant @delatrie @skhomuti