fix no log for failed cases pytest-bdd (fixes #667) #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2dc35b to
d667553
Compare
delatrie
requested changes
Jan 19, 2023
Contributor
delatrie
left a comment
There was a problem hiding this comment.
I think this needs to be implemented more in align with allure-pytest, i.e.:
- Attach not only caplog, but capstdout and capstderr as well.
- Attach always, not only on failures.
Also, the test is needed.
Contributor
|
Implemented in #801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
add caplog for failed cases with pytest-bdd
#667
Checklist