Skip to content

feat(common): add URLSearchParams to request body#37852

Closed
ajitsinghkaler wants to merge 3 commits intoangular:masterfrom
ajitsinghkaler:Url-search-params
Closed

feat(common): add URLSearchParams to request body#37852
ajitsinghkaler wants to merge 3 commits intoangular:masterfrom
ajitsinghkaler:Url-search-params

Conversation

@ajitsinghkaler
Copy link
Contributor

@ajitsinghkaler ajitsinghkaler commented Jun 30, 2020

URLSearch params are by default supported in the browser but are not supported by angular/http package added support for URLSearchParams

Fixes #36317

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No support for URL searchParams

Issue Number: 36317

What is the new behavior?

Support for URL searchParams

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from alxhub June 30, 2020 16:07
@ajitsinghkaler ajitsinghkaler marked this pull request as draft June 30, 2020 16:07
@ajitsinghkaler ajitsinghkaler marked this pull request as ready for review June 30, 2020 16:35
@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented Jun 30, 2020

@gkalpak another size flake

@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented Jun 30, 2020

@alxhub how to get rid of the error in legacy-unit-tests-saucelabs

alfaproject
alfaproject reviewed Jul 1, 2020
View reviewed changes
alfaproject
alfaproject reviewed Jul 1, 2020
View reviewed changes
@AndrewKushnir AndrewKushnir added area: common Issues related to APIs in the @angular/common package feature Issue that requests a new feature labels Jul 1, 2020
@ngbot ngbot bot added this to the needsTriage milestone Jul 1, 2020
@ajitsinghkaler ajitsinghkaler added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 12, 2020
@petebacondarwin petebacondarwin added the area: common/http Issues related to HTTP and HTTP Client label Jan 4, 2021
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 4, 2021
@petebacondarwin petebacondarwin removed the area: common Issues related to APIs in the @angular/common package label Jan 4, 2021
@pullapprove pullapprove bot added the area: common Issues related to APIs in the @angular/common package label Jan 4, 2021
petebacondarwin
petebacondarwin approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@petebacondarwin
Copy link
Contributor

petebacondarwin commented Jan 28, 2021

This is actually a duplicate of #37767, which arrived just before this one.
We are going to go with that if the author is able to make the required changes.
Otherwise we'll come back here. In the meantime I am going to close this one to avoid confusion.

Thanks for the contribution @ajitsinghkaler.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 28, 2021
@petebacondarwin
Copy link
Contributor

petebacondarwin commented Apr 17, 2021

Hi @ajitsinghkaler - #37767 never got updated, so I am re-opening this one. Are you interested in trying to land it?

@angular angular deleted a comment from angular-automatic-lock-bot bot Apr 17, 2021
@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented May 4, 2021

@petebacondarwin I'm interested can you tell me why ci is failing I think its because tests are not working in legacy browser

Can you tell me how to disable it on legacy browsers? Or if there is anything else

@petebacondarwin
Copy link
Contributor

petebacondarwin commented May 4, 2021 •
edited
Loading

The failing tests are probably flakes. I tried restarting them but I think the PR is too old.
Could you rebase on master and see what happens?

@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented May 5, 2021

Yeah sure

@ajitsinghkaler
feat(common): add URLSearchParams to request body
2df9e78 
URLSearch params are by default supported in the browser but are not supported by angular/http package added support for URLSearchParams

Fixes angular#36317
@ajitsinghkaler
Copy link
Contributor Author

ajitsinghkaler commented May 7, 2021 •
edited
Loading

@petebacondarwin rebased it

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 7, 2021
@petebacondarwin petebacondarwin removed the request for review from alxhub May 7, 2021 11:08
@petebacondarwin
Copy link
Contributor

petebacondarwin commented May 7, 2021

Caretaker: I have marked with both presubmit and merge because I am confident that this will sail through G3.

@alxhub alxhub added the target: minor This PR is targeted for the next minor release label May 7, 2021
@alxhub alxhub closed this in 4bc3cf2 May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@alfaproject alfaproject alfaproject left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit area: common/http Issues related to HTTP and HTTP Client area: common Issues related to APIs in the @angular/common package cla: yes feature Issue that requests a new feature target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

HttpClient#post does not serialize native UrlSearchParams

6 participants

@ajitsinghkaler @petebacondarwin @alfaproject @alxhub @googlebot @AndrewKushnir

Comments