refactor(core): remove isObservable TODO#39669
Closed
petebacondarwin wants to merge 1 commit intoangular:masterfrom
Closed
refactor(core): remove isObservable TODO#39669petebacondarwin wants to merge 1 commit intoangular:masterfrom
petebacondarwin wants to merge 1 commit intoangular:masterfrom
Conversation
This commit removes the TODO comment that proposed that we use the built-in RxJS `isObservable()` function. This is not a viable approach since the built-in function requires that the `obj` contains additional methods that our "observable" types (such as `EventEmitter`) do not necessarily have. See angular#39643 for more information.
14 tasks
alfaproject
reviewed
Nov 13, 2020
| export function isObservable(obj: any|Observable<any>): obj is Observable<any> { | ||
| // TODO: use isObservable once we update pass rxjs 6.1 | ||
| // https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#610-2018-05-03 | ||
| return !!obj && typeof obj.subscribe === 'function'; |
Contributor
There was a problem hiding this comment.
To be fair, shouldn't this method be renamed to isSubscribable? It literally checks whether the given object can be subscribed to.
Contributor
Author
There was a problem hiding this comment.
I agree, but to be consistent that is a bigger change, which would involve us changing our use of Observable to Subscribable across the framework.
Contributor
There was a problem hiding this comment.
Yea, agreed. This is also somewhat addressed in #39627 where it actually is renamed to isSubscribable and isObservable is still exported as a type assertion on that function.
gbumanzordev
approved these changes
Nov 13, 2020
atscott
approved these changes
Nov 13, 2020
atscott
pushed a commit
that referenced
this pull request
Nov 16, 2020
This commit removes the TODO comment that proposed that we use the built-in RxJS `isObservable()` function. This is not a viable approach since the built-in function requires that the `obj` contains additional methods that our "observable" types (such as `EventEmitter`) do not necessarily have. See #39643 for more information. PR Close #39669
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the TODO comment that proposed
that we use the built-in RxJS
isObservable()function.This is not a viable approach since the built-in function
requires that the
objcontains additional methods thatour "observable" types (such as
EventEmitter) do notnecessarily have.
See #39643 for more information.