fix(zone.js): defineProperties should also set symbol props by JiaLiPassion · Pull Request #45098 · angular/angular

JiaLiPassion · 2022-02-16T01:35:43Z

Fix defineProperties patch not set symbol props issue.
This is a duplicate PR with #45060, if the 45060 is ok, this one can be closed.

packages/zone.js/lib/browser/define-property.ts

AndrewKushnir · 2022-02-16T20:19:50Z

@JiaLiPassion since this PR inherits the change from #45060, could you please update the commit to use the co-authored-by annotation to capture @varomodt's contribution as well?

JiaLiPassion · 2022-02-16T21:50:42Z

@AndrewKushnir , sure, I updated the commit message, thank you.

AndrewKushnir · 2022-02-16T22:52:18Z

Presubmit.

AndrewKushnir · 2022-02-17T04:00:13Z

Global Presubmit.

varomodt · 2022-02-25T18:43:00Z

Ping: looks like we need to re-run the g3 checks?

lukesandberg · 2022-03-02T19:36:42Z

Ping. Internally we are blocked on this issue

AndrewKushnir · 2022-03-02T20:08:07Z

@lukesandberg sorry for the delay, I did rerun a TGP recently and there is 1 failing target that require an investigation (see here). I will investigate it asap and keep this thread updated.

packages/zone.js/test/browser/define-property.spec.ts

Close angular#44095 Fix `defineProperties` patch not set `symbol` props issue. Co-authored-by: varomodt<varomodt@users.noreply.github.com> Co-authored-by: AndrewKushnir<AndrewKushnir@users.noreply.github.com>

AndrewKushnir · 2022-03-03T05:38:00Z

Global Presubmit #2.

AndrewKushnir · 2022-03-03T20:22:08Z

This PR was merged into the repository by commit b437d12.

Close #44095 Fix `defineProperties` patch not set `symbol` props issue. Co-authored-by: varomodt<varomodt@users.noreply.github.com> Co-authored-by: AndrewKushnir<AndrewKushnir@users.noreply.github.com> PR Close #45098

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.4/13.2.5) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.4/13.2.5) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.4/13.2.5) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.4/13.2.5) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.4/13.2.5) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.4/13.2.5) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.4/13.2.5) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.4/13.2.5) | | [@angular/router](https://github.com/angular/angular) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.4/13.2.5) | | [zone.js](https://github.com/angular/angular) ([changelog](https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | dependencies | patch | [`0.11.4` -> `0.11.5`](https://renovatebot.com/diffs/npm/zone.js/0.11.4/0.11.5) | --- ### Release Notes <details> <summary>angular/angular (@angular/animations)</summary> ### [`v13.2.5`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1325-2022-03-02) [Compare Source](angular/angular@13.2.4...13.2.5) ##### animations | Commit | Type | Description | | -- | -- | -- | | [6c61d20476](angular/angular@6c61d20) | fix | allow animations with unsupported CSS properties ([#45185](angular/angular#45185)) | ##### common | Commit | Type | Description | | -- | -- | -- | | [64da1daa78](angular/angular@64da1da) | fix | canceled JSONP requests won't throw console error with missing callback function ([#36807](angular/angular#36807)) | | [56ca7d385b](angular/angular@56ca7d3) | perf | make `NgLocalization` token tree-shakable ([#45118](angular/angular#45118)) ([#45226](angular/angular#45226)) | ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [6c906a5bb9](angular/angular@6c906a5) | fix | Support resolve animation name from the DTS ([#45169](angular/angular#45169)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [e8fd452bd2](angular/angular@e8fd452) | fix | remove individual commands for updating gold files ([#45198](angular/angular#45198)) | | [82d772857c](angular/angular@82d7728) | perf | make `Compiler`, `ApplicationRef` and `ApplicationInitStatus` tree-shakable ([#45102](angular/angular#45102)) ([#45222](angular/angular#45222)) | | [71ff12c1cc](angular/angular@71ff12c) | perf | make `LOCALE_ID` and other tokens from `ApplicationModule` tree-shakable ([#45102](angular/angular#45102)) ([#45222](angular/angular#45222)) | ##### localize | Commit | Type | Description | | -- | -- | -- | | [d388522745](angular/angular@d388522) | fix | avoid imports into `compiler-cli` package ([#45180](angular/angular#45180)) | #### Special Thanks Andrew Kushnir, Andrew Scott, Charles Lyding, Guillaume Bonnet, Jessica Janiuk, JoostK, Martin Sikora, Paul Gschwendtner, Theodore Brown, dario-piotrowicz and ivanwonder  </details> <details> <summary>angular/angular (zone.js)</summary> ### [`v0.11.5`](https://github.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#0115-httpsgithubcomangularangularcomparezonejs-0114zonejs-0115-2022-03-03) [Compare Source](angular/angular@zone.js-0.11.4...zone.js-0.11.5) ##### Bug Fixes - **zone.js:** async-test should only call done once ([#45025](angular/angular#45025)) ([dea7234](angular/angular@dea7234)) - **zone.js:** defineProperties should also set symbol props ([#45098](angular/angular#45098)) ([b437d12](angular/angular@b437d12)), closes [#44095](angular/angular#44095) - **zone.js:** fix several test cases which trigger `done()` multiple times ([#45025](angular/angular#45025)) ([d5565cc](angular/angular@d5565cc)) - **zone.js:** only one listener should also re-throw an error correctly ([#41868](angular/angular#41868)) ([299f92c](angular/angular@299f92c)), closes [#41867](angular/angular#41867) [/github.com/angular/angular/pull/41562#issuecomment-822696973](https://github.com//github.com/angular/angular/pull/41562/issues/issuecomment-822696973) - **zone.js:** patch global instead of Mocha object ([#45047](angular/angular#45047)) ([8efbdb5](angular/angular@8efbdb5)), closes [#42834](angular/angular#42834) - **zone.js:** should continue to executue listeners when throw error ([#41562](angular/angular#41562)) ([008eaf3](angular/angular@008eaf3)), closes [#41522](angular/angular#41522) - **zone.js:** update several flaky cases ([#41526](angular/angular#41526)) ([25a83eb](angular/angular@25a83eb)), closes [#41434](angular/angular#41434) ##### Features - **zone.js:** add Promise.any() implementation ([#45064](angular/angular#45064)) ([4d494d2](angular/angular@4d494d2)), closes [#44393](angular/angular#44393) - **zone.js:** update electron patch to support electron/remote 14 ([#45073](angular/angular#45073)) ([d65706a](angular/angular@d65706a)), closes [#43346](angular/angular#43346) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1197 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-04-03T16:06:09Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

JiaLiPassion requested a review from AndrewKushnir February 16, 2022 01:35

JiaLiPassion force-pushed the defile-properties branch 2 times, most recently from b2b66cb to 2ddd384 Compare February 16, 2022 02:52

jessicajaniuk added the area: zones Issues related to zone.js label Feb 16, 2022

ngbot bot added this to the Backlog milestone Feb 16, 2022

jessicajaniuk added the target: patch This PR is targeted for the next patch release label Feb 16, 2022

jessicajaniuk reviewed Feb 16, 2022

View reviewed changes

packages/zone.js/lib/browser/define-property.ts Outdated Show resolved Hide resolved

AndrewKushnir approved these changes Feb 16, 2022

View reviewed changes

AndrewKushnir added the action: presubmit The PR is in need of a google3 presubmit label Feb 16, 2022

JiaLiPassion force-pushed the defile-properties branch from 2ddd384 to 2ab8501 Compare February 16, 2022 21:50

JiaLiPassion force-pushed the defile-properties branch from 2ab8501 to 8510163 Compare March 3, 2022 01:14

AndrewKushnir reviewed Mar 3, 2022

View reviewed changes

packages/zone.js/test/browser/define-property.spec.ts Outdated Show resolved Hide resolved

packages/zone.js/test/browser/define-property.spec.ts Outdated Show resolved Hide resolved

fix(zone.js): defineProperties should also set symbol props

c56a283

Close angular#44095 Fix `defineProperties` patch not set `symbol` props issue. Co-authored-by: varomodt<varomodt@users.noreply.github.com> Co-authored-by: AndrewKushnir<AndrewKushnir@users.noreply.github.com>

JiaLiPassion force-pushed the defile-properties branch from 8510163 to c56a283 Compare March 3, 2022 01:35

AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 3, 2022

AndrewKushnir closed this in b437d12 Mar 3, 2022

angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(zone.js): defineProperties should also set symbol props#45098

fix(zone.js): defineProperties should also set symbol props#45098
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:defile-properties

JiaLiPassion commented Feb 16, 2022

Uh oh!

Uh oh!

AndrewKushnir commented Feb 16, 2022

Uh oh!

JiaLiPassion commented Feb 16, 2022

Uh oh!

AndrewKushnir commented Feb 16, 2022

Uh oh!

AndrewKushnir commented Feb 17, 2022

Uh oh!

varomodt commented Feb 25, 2022

Uh oh!

lukesandberg commented Mar 2, 2022

Uh oh!

AndrewKushnir commented Mar 2, 2022

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir commented Mar 3, 2022

Uh oh!

AndrewKushnir commented Mar 3, 2022

Uh oh!

angular-automatic-lock-bot bot commented Apr 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

JiaLiPassion commented Feb 16, 2022

Uh oh!

Uh oh!

AndrewKushnir commented Feb 16, 2022

Uh oh!

JiaLiPassion commented Feb 16, 2022

Uh oh!

AndrewKushnir commented Feb 16, 2022

Uh oh!

AndrewKushnir commented Feb 17, 2022

Uh oh!

varomodt commented Feb 25, 2022

Uh oh!

lukesandberg commented Mar 2, 2022

Uh oh!

AndrewKushnir commented Mar 2, 2022

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir commented Mar 3, 2022

Uh oh!

AndrewKushnir commented Mar 3, 2022

Uh oh!

angular-automatic-lock-bot bot commented Apr 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants