Skip to content

Comments

fix(forms): improve error message for invalid value accessors#45192

Closed
ameryousuf wants to merge 2 commits intoangular:masterfrom
ameryousuf:improve_value_accessor_error_message
Closed

fix(forms): improve error message for invalid value accessors#45192
ameryousuf wants to merge 2 commits intoangular:masterfrom
ameryousuf:improve_value_accessor_error_message

Conversation

@ameryousuf
Copy link
Contributor

@ameryousuf ameryousuf commented Feb 24, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #44486

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dylhunn February 24, 2022 14:10
@ameryousuf ameryousuf force-pushed the improve_value_accessor_error_message branch from 7e15ca1 to c104e66 Compare February 24, 2022 14:41
@ngbot ngbot bot added this to the Backlog milestone Feb 24, 2022
dylhunn
dylhunn suggested changes Feb 25, 2022
View reviewed changes
@AndrewKushnir AndrewKushnir mentioned this pull request Mar 1, 2022
Closed
AndrewKushnir
AndrewKushnir reviewed Mar 1, 2022
View reviewed changes
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 1, 2022
@ameryousuf ameryousuf force-pushed the improve_value_accessor_error_message branch from 65ed10d to 158a7d4 Compare March 13, 2022 16:41
@AndrewKushnir AndrewKushnir requested a review from dylhunn March 15, 2022 01:24
@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 15, 2022
AndrewKushnir
AndrewKushnir approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameryousuf thanks for applying additional changes 👍

The changes look good, I'll run tests in Google's codebase and let you know if there are any specific use-cases that we should address in this PR.

Thank you.

@AndrewKushnir AndrewKushnir requested review from dylhunn and removed request for dylhunn March 15, 2022 01:32
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Mar 15, 2022

Presubmit (internal-only link).

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Mar 15, 2022
@ngbot
Copy link

ngbot bot commented Mar 15, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@AndrewKushnir AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 15, 2022
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Mar 15, 2022

Merge-assistance: the change was reviewed and approved, but Dylan is OOO, so I can't get this PR to the "green" state. The PR is ready for merge.

@atscott
Copy link
Contributor

atscott commented Mar 15, 2022

This PR was merged into the repository by commit 9db9091.

atscott pushed a commit that referenced this pull request Mar 15, 2022
@ameryousuf @atscott
fix(forms): improve error message for invalid value accessors (#45192)
eac94f0 
improve error message for invalid value accessors when accessor is not provided as array

PR Close #45192
@atscott atscott closed this in 9db9091 Mar 15, 2022
atscott pushed a commit that referenced this pull request Mar 15, 2022
@ameryousuf @atscott
fix(forms): improve error message for invalid value accessors (#45192)
7ff4c0b 
improve error message for invalid value accessors when accessor is not provided as array

PR Close #45192
@ameryousuf ameryousuf deleted the improve_value_accessor_error_message branch March 16, 2022 09:20
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 23, 2022
Update angular monorepo to v13.3.0 (#1227)
4e8b371 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.6/13.3.0) |
| [@angular/common](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.6/13.3.0) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.6/13.3.0) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.6/13.3.0) |
| [@angular/core](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.6/13.3.0) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.6/13.3.0) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.6/13.3.0) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.6/13.3.0) |
| [@angular/router](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.6/13.3.0) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v13.3.0`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1330-rc0-2022-03-16)

[Compare Source](angular/angular@13.2.7...13.3.0)

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [b5bb614c74](angular/angular@61a316c) | feat | support TypeScript 4.6 ([#&#8203;45190](angular/angular#45190)) |

#### Special Thanks

Alistair Kane, Andrew Scott and Kristiyan Kostadinov

<!-- CHANGELOG SPLIT MARKER -->

### [`v13.2.7`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1327-2022-03-16)

[Compare Source](angular/angular@13.2.6...13.2.7)

##### forms

| Commit | Type | Description |
| -- | -- | -- |
| [eac94f0945](angular/angular@eac94f0) | fix | improve error message for invalid value accessors ([#&#8203;45192](angular/angular#45192)) |

#### Special Thanks

Alistair Kane, Amer Yousuf, Andrew Scott, Jessica Janiuk, Lee Cooper, alirezaghey and why520crazy

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1227
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 16, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@dylhunn dylhunn Awaiting requested review from dylhunn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@ameryousuf @AndrewKushnir @atscott @dylhunn @jessicajaniuk