Closed
Conversation
Several updates to Angular Package Format. BREAKING CHANGE: Several changes to the Angular Package Format (APF) - Removal of FESM2015 - Replacing ES2020 with ES2022 - Replacing FESM2020 with FESM2022
This commit updates parts of the FW to be ES2022 complaint.
These changes are needed to fix the following problems problems with using properties before they are initialized.
Example
```ts
class Foo {
bar = this.buz;
constructor(private buz: unknown){}
}
```
google-closure-compiler does not support ES2022 (cherry picked from commit 54365418bb8388ffa9b6388ae438e4d6ac4e081d)
These are currently broken due to the APF v16 changes which dropped support for ES2015.
This commit patches `ts_library` to be able to produce `ES2022`. Also, updates the build tsconfig and sets `useDefineForClassFields` to `false` to keep the same behaviour of `ng_module`.
Benchpress requires a decent amount of work to be ES2022 compliant. This will be done in a followup PR.
Contributor
Author
|
Caretaker note: no need for re-approvals as this is an exact re-submit of #49332 |
atscott
approved these changes
Mar 23, 2023
Contributor
|
This PR was merged into the repository by commit 6161c50. |
atscott
pushed a commit
that referenced
this pull request
Mar 23, 2023
This commit updates parts of the FW to be ES2022 complaint.
These changes are needed to fix the following problems problems with using properties before they are initialized.
Example
```ts
class Foo {
bar = this.buz;
constructor(private buz: unknown){}
}
```
PR Close #49559
atscott
pushed a commit
that referenced
this pull request
Mar 23, 2023
google-closure-compiler does not support ES2022 (cherry picked from commit 54365418bb8388ffa9b6388ae438e4d6ac4e081d) PR Close #49559
atscott
pushed a commit
that referenced
this pull request
Mar 23, 2023
These are currently broken due to the APF v16 changes which dropped support for ES2015. PR Close #49559
atscott
pushed a commit
that referenced
this pull request
Mar 23, 2023
This commit patches `ts_library` to be able to produce `ES2022`. Also, updates the build tsconfig and sets `useDefineForClassFields` to `false` to keep the same behaviour of `ng_module`. PR Close #49559
atscott
pushed a commit
that referenced
this pull request
Mar 23, 2023
Benchpress requires a decent amount of work to be ES2022 compliant. This will be done in a followup PR. PR Close #49559
|
大佬好 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several updates to Angular Package Format.
BREAKING CHANGE:
Several changes to the Angular Package Format (APF)
Resubmit of #49332 as it did not causes breakages in G3.
TGP 🟢: http://test/OCL:518773575:BASE:518788596:1679562605010:5c0b8a16