Skip to content

refactor(common): remove old pushState and replaceState code #50109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 wants to merge 1 commit into from
Closed

refactor(common): remove old pushState and replaceState code #50109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions packages/common/src/location/platform_location.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export abstract class PlatformLocation {
}
}

export function useBrowserPlatformLocation() {
function useBrowserPlatformLocation() {
return ɵɵinject(BrowserPlatformLocation);
}

Expand Down Expand Up @@ -101,8 +101,6 @@ export interface LocationChangeListener {
(event: LocationChangeEvent): any;
}



/**
* `PlatformLocation` encapsulates all of the direct calls to platform APIs.
* This class should not be used directly by an application developer. Instead, use
Expand Down Expand Up @@ -167,19 +165,11 @@ export class BrowserPlatformLocation extends PlatformLocation {
}

override pushState(state: any, title: string, url: string): void {
if (supportsState()) {
this._history.pushState(state, title, url);
} else {
this._location.hash = url;
}
this._history.pushState(state, title, url);
}

override replaceState(state: any, title: string, url: string): void {
if (supportsState()) {
this._history.replaceState(state, title, url);
} else {
this._location.hash = url;
}
this._history.replaceState(state, title, url);
}

override forward(): void {
Expand All @@ -199,9 +189,6 @@ export class BrowserPlatformLocation extends PlatformLocation {
}
}

export function supportsState(): boolean {
return !!window.history.pushState;
}
export function createBrowserPlatformLocation() {
function createBrowserPlatformLocation() {
return new BrowserPlatformLocation(ɵɵinject(DOCUMENT));
}