Skip to content

[16.0.x] fix(core): add additional component metadata to component ID generation#50340

Closed
AndrewKushnir wants to merge 1 commit intoangular:16.0.xfrom
AndrewKushnir:add_cmp_metadata_patch
Closed

[16.0.x] fix(core): add additional component metadata to component ID generation#50340
AndrewKushnir wants to merge 1 commit intoangular:16.0.xfrom
AndrewKushnir:add_cmp_metadata_patch

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented May 17, 2023

This commit add exportAs, inputs and outputs into account when generating a component ID.

This PR is effectively a copy of #50336, but without signals field, which became available in main (would be a part of 16.1.0), but not in a patch branch.

PR Type

What kind of change does this PR introduce?

  • Bugfix?

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels May 17, 2023
@AndrewKushnir AndrewKushnir requested a review from alan-agius4 May 17, 2023 03:25
@ngbot ngbot bot added this to the Backlog milestone May 17, 2023
alan-agius4
alan-agius4 reviewed May 17, 2023
View reviewed changes
@AndrewKushnir @alan-agius4
fix(core): add additional component metadata to component ID generation
5794825 
This commit add `exportAs`, `signals`, `inputs` and `outputs` into account when generating a component ID.

Co-authored-by: alan-agius4 <17563226+alan-agius4@users.noreply.github.com>
@AndrewKushnir AndrewKushnir force-pushed the add_cmp_metadata_patch branch from 7f0c89d to 5794825 Compare May 17, 2023 15:07
@AndrewKushnir AndrewKushnir added PullApprove: disable action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 17, 2023
@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented May 17, 2023

This PR was merged into the repository by commit c1016d4.

AndrewKushnir added a commit that referenced this pull request May 17, 2023
@AndrewKushnir
fix(core): add additional component metadata to component ID generati…
c1016d4 
…on (#50340)

This commit add `exportAs`, `signals`, `inputs` and `outputs` into account when generating a component ID.

Co-authored-by: alan-agius4 <17563226+alan-agius4@users.noreply.github.com>

PR Close #50340
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 17, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 left review comments

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewKushnir @alan-agius4