fix(zone.js): enable monkey patching of the `queueMicrotask()` API in node.js by alan-agius4 · Pull Request #50467 · angular/angular

alan-agius4 · 2023-05-25T14:47:51Z

Similar to the browser, now we also monkey patch queueMicrotask in Node.js. This API was added in Node.js 11.

alan-agius4 · 2023-05-25T15:47:32Z

@JiaLiPassion, I am not understanding why some of these tests are failing. Can you please help?

… node.js Similar to the browser, now we also monkey patch `queueMicrotask` in Node.js. This API was added in Node.js 11.

JiaLiPassion

LGTM!

alan-agius4 · 2023-05-26T09:34:11Z

Caretaker note: failures are pre-existing.

dylhunn · 2023-05-30T19:57:47Z

This PR was merged into the repository by commit 381cb98.

… node.js (#50467) Similar to the browser, now we also monkey patch `queueMicrotask` in Node.js. This API was added in Node.js 11. PR Close #50467

…` API in node.js (angular#50467)" This reverts commit 381cb98.

…` API in node.js (#50467)" (#50529) This reverts commit 381cb98. PR Close #50529

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fanimations/16.0.4/16.1.1) | | [@angular/common](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcommon/16.0.4/16.1.1) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/16.0.4/16.1.1) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/16.0.4/16.1.1) | | [@angular/core](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcore/16.0.4/16.1.1) | | [@angular/forms](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fforms/16.0.4/16.1.1) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/16.0.4/16.1.1) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | minor | [`16.0.4` -> `16.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/16.0.4/16.1.1) | | [zone.js](https://github.com/angular/angular) ([changelog](https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | dependencies | patch | [`0.13.0` -> `0.13.1`](https://renovatebot.com/diffs/npm/zone.js/0.13.0/0.13.1) | --- ### Release Notes <details> <summary>angular/angular (@angular/animations)</summary> ### [`v16.1.1`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1611-2023-06-14) [Compare Source](angular/angular@16.1.0...16.1.1) ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [71360b3a3e](angular/angular@71360b3) | fix | libraries compiled with v16.1+ breaking with Angular framework v16.0.x ([#50715](angular/angular#50715)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [d9bed48eb5](angular/angular@d9bed48) | fix | extend toSignal to accept any Subscribable ([#50162](angular/angular#50162)) | ##### migrations | Commit | Type | Description | | -- | -- | -- | | [5e1d8444ae](angular/angular@5e1d844) | fix | Prevent a component from importing itself. ([#50554](angular/angular#50554)) |  ### [`v16.1.0`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1610-2023-06-13) [Compare Source](angular/angular@16.0.6...16.1.0) ##### compiler | Commit | Type | Description | | -- | -- | -- | | [4e663297c5](angular/angular@4e66329) | fix | error when reading compiled input transforms metadata in JIT mode ([#50600](angular/angular#50600)) | | [721bc72649](angular/angular@721bc72) | fix | resolve deprecation warning with TypeScript 5.1 ([#50460](angular/angular#50460)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [68017d4e75](angular/angular@68017d4) | feat | add ability to transform input values ([#50420](angular/angular#50420)) | | [69dadd2502](angular/angular@69dadd2) | feat | support TypeScript 5.1 ([#50156](angular/angular#50156)) | | [c0ebe34cbd](angular/angular@c0ebe34) | fix | add additional component metadata to component ID generation ([#50336](angular/angular#50336)) | ##### http | Commit | Type | Description | | -- | -- | -- | | [85c5427582](angular/angular@85c5427) | feat | Introduction of the `fetch` Backend for the `HttpClient` ([#50247](angular/angular#50247)) |  ### [`v16.0.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1606-2023-06-13) [Compare Source](angular/angular@16.0.5...16.0.6) ##### core | Commit | Type | Description | | -- | -- | -- | | [05ac0868c9](angular/angular@05ac086) | fix | avoid duplicated content during hydration while processing a component with i18n ([#50644](angular/angular#50644)) |  ### [`v16.0.5`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1605-2023-06-08) [Compare Source](angular/angular@16.0.4...16.0.5) ##### compiler | Commit | Type | Description | | -- | -- | -- | | [703b8fcac1](angular/angular@703b8fc) | fix | do not remove comments in component styles ([#50346](angular/angular#50346)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [2b6da93e19](angular/angular@2b6da93) | fix | incorrectly throwing error for self-referencing component ([#50559](angular/angular#50559)) | | [c992109d6c](angular/angular@c992109) | fix | wait for HTTP in `ngOnInit` correctly before server render ([#50573](angular/angular#50573)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [c0d4086c6e](angular/angular@c0d4086) | fix | surface errors during rendering ([#50587](angular/angular#50587)) |  </details> <details> <summary>angular/angular (zone.js)</summary> ### [`v0.13.1`](https://github.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#v0131-httpsgithubcomangularangularcomparezonejs-0130zonejs-v0131-2023-06-09) [Compare Source](angular/angular@zone.js-0.13.0...zone.js-0.13.1) ##### Bug Fixes - **zone.js:** enable monkey patching of the `queueMicrotask()` API in node.js ([#50467](angular/angular#50467)) ([381cb98](angular/angular@381cb98)) - **zone.js:** enable monkey patching of the `queueMicrotask()` API in node.js ([#50530](angular/angular#50530)) ([7837f71](angular/angular@7837f71)) - **zone.js:** patch entire promise in node ([#50552](angular/angular#50552)) ([cb31dbc](angular/angular@cb31dbc)), closes [#50513](angular/angular#50513) [#50457](angular/angular#50457) [#50414](angular/angular#50414) [#49930](angular/angular#49930) - **zone.js:** revert Mocha it.skip, describe.skip method patch ([#49329](angular/angular#49329)) ([5a2b622](angular/angular@5a2b622)) ##### Features - **zone.js:** jest 29 should ignore uncaught error console log ([#49325](angular/angular#49325)) ([bc412fd](angular/angular@bc412fd)), closes [#49110](angular/angular#49110) ##### Reverts - Revert "fix(zone.js): enable monkey patching of the `queueMicrotask()` API in node.js ([#50467](angular/angular#50467))" ([#50529](angular/angular#50529)) ([7567348](angular/angular@7567348)), closes [#50467](angular/angular#50467) [#50529](angular/angular#50529) [#50529](angular/angular#50529) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1927 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2023-06-30T00:09:53Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

… node.js (angular#50467) Similar to the browser, now we also monkey patch `queueMicrotask` in Node.js. This API was added in Node.js 11. PR Close angular#50467

alan-agius4 added target: patch This PR is targeted for the next patch release area: zones Issues related to zone.js labels May 25, 2023

ngbot bot added this to the Backlog milestone May 25, 2023

alan-agius4 force-pushed the zone.js-micro-task branch from 736d527 to acc1292 Compare May 25, 2023 15:26

alan-agius4 closed this May 25, 2023

alan-agius4 reopened this May 25, 2023

alan-agius4 closed this May 25, 2023

alan-agius4 force-pushed the zone.js-micro-task branch from acc1292 to 06b498f Compare May 25, 2023 15:44

alan-agius4 reopened this May 25, 2023

alan-agius4 self-assigned this May 25, 2023

fix(zone.js): enable monkey patching of the queueMicrotask() API in…

320e70a

… node.js Similar to the browser, now we also monkey patch `queueMicrotask` in Node.js. This API was added in Node.js 11.

alan-agius4 marked this pull request as ready for review May 26, 2023 04:55

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 26, 2023

alan-agius4 requested a review from JiaLiPassion May 26, 2023 04:55

alan-agius4 force-pushed the zone.js-micro-task branch from e893c3a to 320e70a Compare May 26, 2023 04:55

JiaLiPassion approved these changes May 26, 2023

View reviewed changes

alan-agius4 force-pushed the zone.js-micro-task branch from 8c42afd to 320e70a Compare May 26, 2023 08:38

alan-agius4 added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: presubmit The PR is in need of a google3 presubmit labels May 26, 2023

dylhunn closed this in 381cb98 May 30, 2023

alan-agius4 deleted the zone.js-micro-task branch May 30, 2023 19:59

jessicajaniuk mentioned this pull request May 31, 2023

Revert "fix(zone.js): enable monkey patching of the `queueMicrotask()… #50529

Closed

jessicajaniuk pushed a commit to jessicajaniuk/angular that referenced this pull request May 31, 2023

Revert "fix(zone.js): enable monkey patching of the `queueMicrotask()…

fa3cef6

…` API in node.js (angular#50467)" This reverts commit 381cb98.

dylhunn pushed a commit that referenced this pull request May 31, 2023

Revert "fix(zone.js): enable monkey patching of the `queueMicrotask()…

7567348

…` API in node.js (#50467)" (#50529) This reverts commit 381cb98. PR Close #50529

dylhunn pushed a commit that referenced this pull request May 31, 2023

Revert "fix(zone.js): enable monkey patching of the `queueMicrotask()…

55244e6

…` API in node.js (#50467)" (#50529) This reverts commit 381cb98. PR Close #50529

alan-agius4 mentioned this pull request Jun 1, 2023

fix(zone.js): enable monkey patching of the queueMicrotask() API in node.js [Take 2] #50530

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(zone.js): enable monkey patching of the `queueMicrotask()` API in node.js#50467

fix(zone.js): enable monkey patching of the `queueMicrotask()` API in node.js#50467
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:zone.js-micro-task

alan-agius4 commented May 25, 2023

Uh oh!

alan-agius4 commented May 25, 2023

Uh oh!

JiaLiPassion left a comment

Uh oh!

alan-agius4 commented May 26, 2023

Uh oh!

dylhunn commented May 30, 2023

Uh oh!

angular-automatic-lock-bot bot commented Jun 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

alan-agius4 commented May 25, 2023

Uh oh!

alan-agius4 commented May 25, 2023

Uh oh!

JiaLiPassion left a comment

Choose a reason for hiding this comment

Uh oh!

alan-agius4 commented May 26, 2023

Uh oh!

dylhunn commented May 30, 2023

Uh oh!

angular-automatic-lock-bot bot commented Jun 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants