refactor(animations): remove unecessary interface#50662
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(animations): remove unecessary interface#50662JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
1528d9c to
a6c5ab2
Compare
`Animation` is provided by `lib.dom`.
a6c5ab2 to
1e1f7ee
Compare
jessicajaniuk
approved these changes
Jun 20, 2023
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM
I think this should be fine in Google, but just to be safe I'll run a TGP.
Member
Author
|
@jessicajaniuk Can we move forward on this ? |
Contributor
|
@JeanMeche Yes, but we still need to run the TGP. That's the hold up. |
Contributor
Contributor
|
Caretaker: TGP is green. This is ready to merge. |
Contributor
|
This PR was merged into the repository by commit 10bab47. |
dylhunn
pushed a commit
that referenced
this pull request
Aug 7, 2023
`Animation` is provided by `lib.dom`. PR Close #50662
dylhunn
pushed a commit
that referenced
this pull request
Aug 7, 2023
`Animation` is provided by `lib.dom`. PR Close #50662
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
`Animation` is provided by `lib.dom`. PR Close angular#50662
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Animationis provided bylib.dom.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?