Skip to content

Revert "fix(router): Ensure canMatch guards run on wildcard routes (#…#53339

Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:revert-router
Closed

Revert "fix(router): Ensure canMatch guards run on wildcard routes (#…#53339
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:revert-router

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Dec 3, 2023

…53239)"

This reverts commit 1940280.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@dylhunn dylhunn requested a review from atscott December 3, 2023 22:31
@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 3, 2023
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 3, 2023
@dylhunn dylhunn removed the request for review from atscott December 3, 2023 22:57
@pullapprove pullapprove bot requested a review from AndrewKushnir December 3, 2023 22:57
@dylhunn
Copy link
Contributor Author

dylhunn commented Dec 3, 2023

This PR was merged into the repository by commit d4b4236.

@dylhunn dylhunn closed this in d4b4236 Dec 3, 2023
dylhunn added a commit that referenced this pull request Dec 3, 2023
atscott added a commit to atscott/angular that referenced this pull request Dec 4, 2023
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
dylhunn pushed a commit that referenced this pull request Dec 6, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2024
ChellappanRajan pushed a commit to ChellappanRajan/angular that referenced this pull request Jan 23, 2024
rlmestre pushed a commit to rlmestre/angular that referenced this pull request Jan 26, 2024
amilamen pushed a commit to amilamen/angular that referenced this pull request Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments