Skip to content

Comments

refactor(core): update AnimationCallbackEvent.animationComplete signature#65616

Merged
thePunderWoman merged 1 commit intoangular:mainfrom
goulaheau:feat/65613-animation-complete-signature
Feb 20, 2026
Merged

refactor(core): update AnimationCallbackEvent.animationComplete signature#65616
thePunderWoman merged 1 commit intoangular:mainfrom
goulaheau:feat/65613-animation-complete-signature

Conversation

@goulaheau
Copy link
Contributor

@goulaheau goulaheau commented Nov 25, 2025 •
edited
Loading

Fixes #65613

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The Function type is not precise enough and is in error with this rule :
https://typescript-eslint.io/rules/no-unsafe-call/

Issue Number: #65613

What is the new behavior?

The Function is replaced for () => void, which is more precise.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from thePunderWoman November 25, 2025 10:51
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Nov 25, 2025
@ngbot ngbot bot added this to the Backlog milestone Nov 25, 2025
@JeanMeche JeanMeche modified the milestones: Backlog, v22 candidates Nov 25, 2025
@JeanMeche JeanMeche marked this pull request as draft November 25, 2025 13:59
@JeanMeche
Copy link
Member

JeanMeche commented Nov 25, 2025

This is actually a breaking change that we can't land until we're in a breaking change window again.

@goulaheau
Copy link
Contributor Author

goulaheau commented Nov 25, 2025

@JeanMeche Ok, I updated the description, should I do anything more ?

@JeanMeche
Copy link
Member

JeanMeche commented Nov 25, 2025

There isn't much to do until late febuary, our next breaking change window for v22.
Also the commit should be more of a refactor than a feat.

thePunderWoman
thePunderWoman reviewed Nov 25, 2025
View reviewed changes
@goulaheau goulaheau force-pushed the feat/65613-animation-complete-signature branch 2 times, most recently from 85542ad to 3820669 Compare November 25, 2025 19:38
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Nov 25, 2025
@goulaheau goulaheau changed the title feat(core): update AnimationCallbackEvent.animationComplete signature refactor(core): update AnimationCallbackEvent.animationComplete signature Feb 4, 2026
@goulaheau goulaheau marked this pull request as ready for review February 4, 2026 08:48
@JeanMeche JeanMeche added the target: major This PR is targeted for the next major release label Feb 20, 2026
@JeanMeche JeanMeche force-pushed the feat/65613-animation-complete-signature branch from 3820669 to e8687eb Compare February 20, 2026 00:05
@JeanMeche JeanMeche added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Feb 20, 2026
@goulaheau @JeanMeche
refactor(core): enhance AnimationCallbackEvent.animationComplete sign…
25d0e5b 
…ature

BREAKING CHANGE: change AnimationCallbackEvent.animationComplete signature

Fixes angular#65613
@JeanMeche JeanMeche force-pushed the feat/65613-animation-complete-signature branch from e8687eb to 25d0e5b Compare February 20, 2026 12:37
@pullapprove pullapprove bot requested a review from crisbeto February 20, 2026 17:01
@pullapprove pullapprove bot requested a review from JeanMeche February 20, 2026 17:01
@pullapprove pullapprove bot requested a review from thePunderWoman February 20, 2026 17:01
thePunderWoman
thePunderWoman approved these changes Feb 20, 2026
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-general, public-api

@pullapprove pullapprove bot requested a review from crisbeto February 20, 2026 17:01
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 20, 2026
@ngbot
Copy link

ngbot bot commented Feb 20, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman thePunderWoman merged commit b9b5c27 into angular:main Feb 20, 2026
20 checks passed
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Feb 20, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime breaking changes detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Milestone

v22 candidates

Development

Successfully merging this pull request may close these issues.

Change signature of animationComplete from AnimationCallbackEvent to be more precise

3 participants

@goulaheau @JeanMeche @thePunderWoman