Skip to content

refactor(core): remove unused generics & improve tree-shaking #66459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SkyZeroZx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(core): remove unused generics & improve tree-shaking #66459

SkyZeroZx wants to merge 1 commit into from
+6 −4

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Jan 10, 2026 •
edited
Loading

Removes unused generic parameters from functions where <T> was not used. Improves tree-shaking by passing the injector type to 'NodeInjector' only in dev mode.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from crisbeto January 10, 2026 23:22
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jan 10, 2026
@ngbot ngbot bot added this to the Backlog milestone Jan 10, 2026
@SkyZeroZx SkyZeroZx force-pushed the refactor-cleanup branch 2 times, most recently from 362393a to 368357a Compare January 12, 2026 22:14
@SkyZeroZx
refactor(core): remove unused generics & improve tree-shaking
15c48cf 
Removes unused generic parameters from functions where `<T>` was not used.
Improves tree-shaking by passing the injector type to
'NodeInjector' only in dev mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

No one assigned

Labels

area: core Issues related to the framework runtime

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

1 participant

@SkyZeroZx