Skip to content

Conversation

@JeanMeche
Copy link
Member

#65760 implemented the transform support backwards. FormUiControl should expect the given type as input but it shouldn't care what the output of the transform is.

@JeanMeche JeanMeche force-pushed the form-ui-control-transforms branch from 61a8b96 to acd20c3 Compare January 14, 2026 00:37
@ngbot ngbot bot added this to the Backlog milestone Jan 14, 2026
@JeanMeche JeanMeche force-pushed the form-ui-control-transforms branch 9 times, most recently from d3d77ba to 32f3061 Compare January 14, 2026 14:07
@JeanMeche JeanMeche marked this pull request as ready for review January 14, 2026 14:09
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-general, fw-compiler, public-api

@pullapprove pullapprove bot requested a review from atscott January 14, 2026 15:51
@JeanMeche JeanMeche force-pushed the form-ui-control-transforms branch 2 times, most recently from eb6a4c7 to dc1bf44 Compare January 14, 2026 16:55
});

it('can retrieve a symbol for a signal-input binding', () => {
xit('can retrieve a symbol for a signal-input binding', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be excluded

@JeanMeche JeanMeche marked this pull request as draft January 14, 2026 19:43
@JeanMeche JeanMeche closed this Jan 14, 2026
@JeanMeche JeanMeche force-pushed the form-ui-control-transforms branch from dc1bf44 to c9f584b Compare January 14, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants