Skip to content

docs(docs-infra): use Signals Forms focusBoundControl #66528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thePunderWoman merged 1 commit into from
Jan 14, 2026
Merged

docs(docs-infra): use Signals Forms focusBoundControl #66528

thePunderWoman merged 1 commit into from
Jan 14, 2026
+3 −7

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Jan 14, 2026

Removes direct ViewChild access from TextField components and relies on Signals Forms via the focusBoundControl to manage focus.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@SkyZeroZx
docs(docs-infra): use Signals Forms focusBoundControl
2c71d5f 
Removes direct `ViewChild` access from `TextField` components and relies on
Signals Forms via the `focusBoundControl`  to manage focus.
@pullapprove pullapprove bot requested a review from jelbourn January 14, 2026 00:55
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Jan 14, 2026
@ngbot ngbot bot added this to the Backlog milestone Jan 14, 2026
JeanMeche
JeanMeche approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it 😄😄

@JeanMeche JeanMeche removed the request for review from jelbourn January 14, 2026 01:03
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

Deployed adev-preview for 2c71d5f to: https://ng-dev-previews-fw--pr-angular-angular-66528-adev-prev-t3x2egau.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 14, 2026
@thePunderWoman thePunderWoman merged commit 074666b into angular:main Jan 14, 2026
27 checks passed
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jan 14, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@SkyZeroZx @thePunderWoman @JeanMeche