feat(language-service): add Angular-specific Inlay Hints (LSP 3.17)#66755
feat(language-service): add Angular-specific Inlay Hints (LSP 3.17)#66755kbrilla wants to merge 4 commits intoangular:mainfrom
Conversation
| const tsHints = languageService.provideInlayHints(scriptInfo.fileName, span, tsPreferences); | ||
|
|
||
| for (const tsHint of tsHints) { | ||
| const position = scriptInfo.positionToLineOffset(tsHint.position); | ||
| hints.push(convertTsInlayHint(tsHint, position)); | ||
| } |
There was a problem hiding this comment.
From my testing, this should be omitted. Typescript provides its own inlay hints and we should not duplicate them.
There was a problem hiding this comment.
I removed TS inlay hints from Angular response
| "default": true, | ||
| "markdownDescription": "When enabled, the Angular Language Service will delegate file watching to VS Code instead of creating its own internal file watchers. This can significantly improve performance (greater than 10x faster initialization) and reduce resource usage in large repositories." | ||
| }, | ||
| "angular.inlayHints.forLoopVariableTypes": { |
There was a problem hiding this comment.
I think all of these should be defaulted to their "off" equivalents
There was a problem hiding this comment.
Done. I switched Angular inlay hint options to off by default. I also cleaned up config handling so toggles apply live without requiring extension restart.
| "default": true, | ||
| "markdownDescription": "When enabled, the Angular Language Service will delegate file watching to VS Code instead of creating its own internal file watchers. This can significantly improve performance (greater than 10x faster initialization) and reduce resource usage in large repositories." | ||
| }, | ||
| "angular.inlayHints.forLoopVariableTypes": { |
There was a problem hiding this comment.
Now that we have so many options, we could benefit from better grouping like typescript has
There was a problem hiding this comment.
Added Inlay Hints subcategory, and grouped existing settings into Preferences subcategory. Should we split it even more? Suggestions, Diagnostics?
|
@kbrilla Do you plan on continuing work on this PR? |
|
, I was not able to look into it today, but will continue tomorrow |
1197eaa to
d5f5c93
Compare
c1e6168 to
abefeba
Compare
|
Updated PR description and added screenshots |
3129013 to
a088340
Compare
…ettings grouping Add shared workspace configuration helper utilities and move extension settings to grouped configuration sections, without inlay-hint feature options yet.
Add Angular template inlay hints end-to-end across language-service and VS Code extension server/client wiring, including inlay-specific configuration mapping, request guards, and refresh behavior.
a088340 to
4ccf175
Compare
PR Checklist
PR Type
What is the current behavior?
Issue Number: #66730
What is the new behavior?
This PR adds Angular-specific template inlay hints end-to-end across the language service and VS Code extension.
It also includes a small server-side workspace configuration helper refactor so inlay hint settings can be pulled and refreshed cleanly.
Highlights:
textDocument/inlayHintandinlayHint/resolvesupport in the extension server.Does this PR introduce a breaking change?
Other information
Screenshots