refactor(core): guards stringify calls with ngDevMode#66958
refactor(core): guards stringify calls with ngDevMode#66958thePunderWoman merged 3 commits intoangular:mainfrom
Conversation
| } | ||
|
|
||
| return new R3Injector(providers, parent || getNullInjector(), name || null, scopes); | ||
| return new R3Injector(providers, parent || getNullInjector(), source || null, scopes); |
There was a problem hiding this comment.
This value, as I understand it, is only used in dev
angular/packages/core/src/di/r3_injector.ts
Lines 401 to 410 in 63d828a
| try { | ||
| if (record.value === CIRCULAR) { | ||
| throw cyclicDependencyError(stringify(token)); | ||
| throw cyclicDependencyError(ngDevMode ? stringify(token) : ''); |
There was a problem hiding this comment.
We have a similar case here; the value is only used for dev mode.
angular/packages/core/src/render3/errors_di.ts
Lines 24 to 27 in 63d828a
JeanMeche
left a comment
There was a problem hiding this comment.
That change looks mostly good to me.
|
A rebase on main should "fix" the linting issue. |
The `stringify` function is only needed for debugging purposes and should not be called in production mode.
e06f4c2 to
81add45
Compare
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
caretaker note: The failed test is a known flake. |
The
stringifyfunction is only needed for debugging purposes and should not be called in production mode.