refactor(common): log a warning when a JsonPipe receives a signal#66993
Open
JeanMeche wants to merge 1 commit intoangular:mainfrom
Open
refactor(common): log a warning when a JsonPipe receives a signal#66993JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
reviewed
Feb 10, 2026
9a5cf06 to
5aeda4f
Compare
5aeda4f to
927844a
Compare
927844a to
02fd72e
Compare
The JsonPipe does not unwrap signals and `JSON.stringify` will return `undefined` for signals. To avoid confusion, we log a warning when a signal is passed to the pipe.
02fd72e to
87bdf78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JsonPipe does not unwrap signals and
JSON.stringifywill returnundefinedfor signals.To avoid confusion, we log a warning when a signal is passed to the pipe.