Conversation
Add testing tips to AGENTS.md
atscott
left a comment
There was a problem hiding this comment.
I tested this out by converting the contents of packages/core/test/acceptance/control_flow_for_spec.ts to an outline, then asking gemini to create the tests. It stuck to the old detectChanges style and I asked why and iterated on the agents file from there. I think this gave better outcomes:
## Testing
- **Zoneless & Async-First:** Assume a zoneless environment where state changes schedule updates asynchronously.
- **Do NOT** use `fixture.detectChanges()` to manually trigger updates.
- **ALWAYS** use the "Act, Wait, Assert" pattern:
1. **Act:** Update state or perform an action.
2. **Wait:** `await fixture.whenStable()` to allow the framework to process the scheduled update.
3. **Assert:** Verify the output.
- To keep tests fast, minimize the need for waiting:
- Use `useAutoTick()` (from `packages/private/testing/src/utils.ts`) to fast-forward time via the mock clock.
- When waiting is necessary, use real async tests (`it('...', async () => { ... })`) along with:
- `await timeout(ms)` (from `packages/private/testing/src/utils.ts`) to wait a specific number of milliseconds.
- `await fixture.whenStable()` to wait for framework stability.
I do think this misses the nuance of whenStable not working in all scenarios but that is probably fine for most use-cases.
|
yeah I also found it difficult to get it away from |
Co-authored-by: Joey Perrott <josephperrott@gmail.com>
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
@atscott This is still in a state of "requested changes" but Miles added the merge label. Are your requests required to merge? |
Add testing tips to AGENTS.md