refactor(core): remove outdated TODO comments referencing TypeScript 2.1#67069
Open
Rajveer173 wants to merge 1 commit intoangular:mainfrom
Open
refactor(core): remove outdated TODO comments referencing TypeScript 2.1#67069Rajveer173 wants to merge 1 commit intoangular:mainfrom
Rajveer173 wants to merge 1 commit intoangular:mainfrom
Conversation
Angular requires TypeScript >=5.9, making TODO comments that reference TypeScript 2.1 features obsolete. These comments existed in keyvalue_differs.ts and ng_for_of.ts and referenced type improvements that were deferred until TS 2.1, which has long since been surpassed.
JeanMeche
approved these changes
Feb 14, 2026
Member
JeanMeche
left a comment
There was a problem hiding this comment.
Yeah, it's unlikely we'll do that change.
Member
|
Caretaker note: This is comment only change, this doesn't need a presubmit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
The files keyvalue_differs.ts and ng_for_of.ts contain outdated TODO comments referencing TypeScript 2.1 features. Angular now requires TypeScript >= 5.9, making those comments obsolete.
Issue Number: N/A
What is the new behavior?
Removed outdated TypeScript 2.1 TODO comments.
No functional changes.
No API changes.
Does this PR introduce a breaking change?
Other information
This change removes legacy comments that are no longer relevant and improves maintainability.