fix(common): allow mixed pixel and responsive values in NgOptimizedIm…#67070
Open
Rajveer173 wants to merge 1 commit intoangular:mainfrom
Open
fix(common): allow mixed pixel and responsive values in NgOptimizedIm…#67070Rajveer173 wants to merge 1 commit intoangular:mainfrom
Rajveer173 wants to merge 1 commit intoangular:mainfrom
Conversation
…age sizes The assertNoComplexSizes validation in NgOptimizedImage previously rejected any sizes attribute containing pixel values, even when those pixel values appeared alongside responsive units like vw. This prevented valid use cases where a pixel fallback is intentionally combined with responsive media queries. The heuristic now only throws when the sizes attribute contains exclusively pixel values with no responsive units, which indicates the user likely wants fixed-size mode and should omit sizes to get proper 1x/2x density descriptors instead. Fixes angular#59495
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59495
PR Checklist
PR Type
What is the current behavior?
The assertNoComplexSizes validation in NgOptimizedImage rejects any
sizesattribute containing pixel (px) values, even when those pixel values are used alongside responsive units such asvw.This prevents valid use cases where a pixel fallback is intentionally combined with responsive media queries.
What is the new behavior?
The heuristic now throws only when the
sizesattribute contains exclusively pixel values and no responsive units.If responsive units (e.g.,
vw) are present alongside pixel values, validation passes.This ensures:
sizesand rely on 1x/2x density descriptors.Does this PR introduce a breaking change?
Other information
This change aligns validation behavior with real-world responsive image patterns while preserving guidance for fixed-size usage.