feat(forms): add valueChanges, statusChanges and events support in InteropNgControl#67087
Open
riccardoperra wants to merge 1 commit intoangular:mainfrom
Open
feat(forms): add valueChanges, statusChanges and events support in InteropNgControl#67087riccardoperra wants to merge 1 commit intoangular:mainfrom
valueChanges, statusChanges and events support in InteropNgControl#67087riccardoperra wants to merge 1 commit intoangular:mainfrom
Conversation
65310bb to
d5f9ea0
Compare
…ropNgControl Improve InteropNgControl interoperability with NgControl for form implementations that rely on NgControl injection while using a field with FormFieldDirective, by exposing the following missing properties: - valueChanges - statusChanges - events
d5f9ea0 to
7ccbe6d
Compare
valueChanges, statusChanges and events support in interop_ng_controlvalueChanges, statusChanges and events support in InteropNgControl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
interop_ng_controlimplementation does not expose several commonly usedNgControlAPIs when injected inside custom ControlValueAccessor implementations:This mean that existing directives and abstractions built for template driven or reactive forms cannot be reused while using the new
formFielddirective.Example: https://github.com/taiga-family/taiga-ui/blob/main/projects/cdk/classes/control.ts#L83
I intentionally avoided introducing a dependency in bazel on rxjs/rxjs-interop in order to keep signal-based forms independent from RxJS-specific implementation details.