refactor(core): rename primitives/di inject to injectFromCurrentInjector#67098
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
refactor(core): rename primitives/di inject to injectFromCurrentInjector#67098arturovt wants to merge 1 commit intoangular:mainfrom
arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
Both @angular/core and @angular/core/primitives/di export a function named inject, causing a named export conflict when merging into a single SystemJS bundle. Rename the primitives/di version to injectFromCurrentInjector to reflect its actual behavior and align with the existing getCurrentInjector and setCurrentInjector naming convention in that module.
Contributor
|
I don't think this is something we would change as it has internal implications. Thank you though! |
Contributor
Author
|
@thePunderWoman I understand this is internal, but the fact that it's internal doesn't mean it can't impact developers. When bundling Angular packages for SystemJS (which is required for single-spa microfrontends), these primitives are pulled in transitively and the naming conflict causes real runtime issues. The internal/public distinction breaks down at the bundling layer. Would love to hear if there's a recommended approach for this use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both @angular/core and @angular/core/primitives/di export a function named inject, causing a named export conflict when merging into a single SystemJS bundle. Rename the primitives/di version to injectFromCurrentInjector to reflect its actual behavior and align with the existing getCurrentInjector and setCurrentInjector naming convention in that module.