test(core): Adds and uses a waitFor helper#67101
Open
atscott wants to merge 1 commit intoangular:mainfrom
Open
test(core): Adds and uses a waitFor helper#67101atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
thePunderWoman
approved these changes
Feb 17, 2026
| fixture.detectChanges(); | ||
| expect(fixture.nativeElement.textContent).toBe(''); | ||
| fixture.componentInstance.case.set(3); | ||
| await expectScreenText(' case 3-4 ', {container: fixture.nativeElement}); |
Contributor
There was a problem hiding this comment.
My only feedback is that the passing of {container: fixture.nativeElement} is very repetitive. I wish this was default and instead could just be overridden.
Contributor
Author
There was a problem hiding this comment.
The problem is the node tests, where we can't just read document, combined with the fact that TestBed isn't like catalyst where we can get the last fixture. Maybe we can extend TestBed static to have something like TestBed.lastFixture() or something.
This adds a waitFor utility inspired by tools like testing-library and convers a zone-based test to the zoneless waitFor
da6c56e to
bd56ab7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a waitFor utility inspired by tools like testing-library and convers a zone-based test to the zoneless waitFor