Skip to content

refactor(forms): remove unused generic type parameter#67102

Merged
mattrbeck merged 1 commit intoangular:mainfrom
leonsenft:sf-cleanup
Feb 17, 2026
Merged

refactor(forms): remove unused generic type parameter#67102
mattrbeck merged 1 commit intoangular:mainfrom
leonsenft:sf-cleanup

Conversation

@leonsenft
Copy link
Contributor

@leonsenft leonsenft commented Feb 17, 2026

The TValue type parameter was unused by FormUiControl.

@leonsenft
refactor(forms): remove unused generic type parameter
4d7099c 
The `TValue` type parameter was unused by `FormUiControl`.
@leonsenft leonsenft requested a review from kirjs February 17, 2026 19:00
@leonsenft leonsenft added area: forms target: minor This PR is targeted for the next minor release forms: signals labels Feb 17, 2026
@ngbot ngbot bot added this to the Backlog milestone Feb 17, 2026
@leonsenft leonsenft marked this pull request as ready for review February 17, 2026 19:14
@pullapprove pullapprove bot requested a review from JeanMeche February 17, 2026 19:14
@pullapprove pullapprove bot requested a review from atscott February 17, 2026 20:16
kirjs
kirjs reviewed Feb 17, 2026
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

kirjs
kirjs approved these changes Feb 17, 2026
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@leonsenft leonsenft added the action: merge The PR is ready for merge by the caretaker label Feb 17, 2026
@ngbot
Copy link

ngbot bot commented Feb 17, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "pullapprove" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mattrbeck mattrbeck merged commit b481294 into angular:main Feb 17, 2026
26 checks passed
@mattrbeck
Copy link
Member

mattrbeck commented Feb 17, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirjs kirjs kirjs approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms forms: signals target: minor This PR is targeted for the next minor release

Projects

Experimental Signal Forms
Status: Done

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@leonsenft @mattrbeck @kirjs