Skip to content

refactor(forms): simplify destroy subject handling#67104

Merged
mattrbeck merged 1 commit intoangular:mainfrom
SkyZeroZx:sf-refactor-types
Feb 18, 2026
Merged

refactor(forms): simplify destroy subject handling#67104
mattrbeck merged 1 commit intoangular:mainfrom
SkyZeroZx:sf-refactor-types

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Feb 17, 2026

Remove unnecessary conditional check when completing the destroy subject, since it is always defined

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Remove unnecessary conditional check when completing the destroy subject, since it is always defined
@pullapprove pullapprove bot requested a review from AndrewKushnir February 17, 2026 20:09
@ngbot ngbot bot added this to the Backlog milestone Feb 17, 2026
@JeanMeche JeanMeche requested review from kirjs and removed request for AndrewKushnir February 17, 2026 21:01
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 18, 2026
@mattrbeck mattrbeck merged commit fd956f6 into angular:main Feb 18, 2026
23 checks passed
@mattrbeck
Copy link
Member

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: forms target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments