docs(docs-infra): fixed missing gray color palette definitions for li…#67123
Open
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Open
docs(docs-infra): fixed missing gray color palette definitions for li…#67123SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
Conversation
…ght and dark modes Adds the missing gray color palette definitions for both light and dark modes
JeanMeche
reviewed
Feb 18, 2026
Comment on lines
+231
to
+241
| --gray-1000: #{$gray-1000}; | ||
| --gray-900: #{$gray-900}; | ||
| --gray-800: #{$gray-800}; | ||
| --gray-700: #{$gray-700}; | ||
| --gray-600: #{$gray-600}; | ||
| --gray-500: #{$gray-500}; | ||
| --gray-400: #{$gray-400}; | ||
| --gray-300: #{$gray-300}; | ||
| --gray-200: #{$gray-200}; | ||
| --gray-100: #{$gray-100}; | ||
| --gray-50: #{$gray-50}; |
Member
There was a problem hiding this comment.
The variables were removed by #66822 and shouldn't be used directly.
Contributor
Author
There was a problem hiding this comment.
So, should we use the contrast variables we have according to light or dark theme?
angular/adev/shared-docs/styles/_colors.scss
Lines 220 to 228 in ac8b5ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing gray color palette definitions for both light and dark modes
What is the current behavior?
https://next.angular.dev/best-practices/a11y
What is the new behavior?
Does this PR introduce a breaking change?