fix(upgrade): prevent APP_BASE_HREF duplication in locationShim.path#67157
Open
atscott wants to merge 1 commit intoangular:mainfrom
Open
fix(upgrade): prevent APP_BASE_HREF duplication in locationShim.path#67157atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
When receives URL updates from Location.onUrlChange, it expects an internal path. However, Location emits the external path which includes the configured baseHref. Parsing this external path caused the baseHref parameter to be duplicated within locationShim.path. This commit updates to use Location.normalize() to strip the baseHref from the emitted URL before parsing it. This is not a breaking change as the Subject is private, and its subscriber expects an internal URL. Emitting the correct internal URL ensures public API functions and events like carry accurate paths without duplication. fixes angular#67153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When receives URL updates from Location.onUrlChange, it expects an internal path. However, Location emits the external path which includes the configured baseHref. Parsing this external path caused the baseHref parameter to be duplicated within locationShim.path.
This commit updates to use Location.normalize() to strip the baseHref from the emitted URL before parsing it.
This is not a breaking change as the Subject is private, and its subscriber expects an internal URL. Emitting the correct internal URL ensures public API functions and events like
carry accurate paths without duplication.
fixes #67153