Skip to content

fix(forms): preserve parse errors when parse returns value#67171

Open
cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat:fix/forms-parse-errors-with-value
Open

fix(forms): preserve parse errors when parse returns value#67171
cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat:fix/forms-parse-errors-with-value

Conversation

@cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Feb 20, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #67170

What is the new behavior?

Keeps the errors even if a value is returned from parse

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cexbrayat
fix(forms): preserve parse errors when parse returns value
aa33022 
Fixes angular#67170 by keeping the errors even a value is returned from the parse function.
@pullapprove pullapprove bot requested a review from kirjs February 20, 2026 11:04
@ngbot ngbot bot added this to the Backlog milestone Feb 20, 2026
@cexbrayat cexbrayat mentioned this pull request Feb 20, 2026
Open
@JeanMeche JeanMeche requested review from mmalerba and removed request for kirjs February 20, 2026 12:54
mmalerba
mmalerba approved these changes Feb 20, 2026
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Feb 20, 2026
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Feb 20, 2026
@ngbot
Copy link

ngbot bot commented Feb 20, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
    pending status "google-internal-tests" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@JeanMeche JeanMeche added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms forms: signals target: rc This PR is targeted for the next release-candidate

Projects

Experimental Signal Forms
Status: No status

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@cexbrayat @mmalerba @JeanMeche

Comments