fix(docs-infra): use shared heading ID generation logic#67201
Merged
thePunderWoman merged 1 commit intoangular:mainfrom Feb 23, 2026
Merged
fix(docs-infra): use shared heading ID generation logic#67201thePunderWoman merged 1 commit intoangular:mainfrom
thePunderWoman merged 1 commit intoangular:mainfrom
Conversation
This commit extracts the heading ID generation logic into a shared utility
and updates both the route generation script and the markdown pipeline to use it.
This ensures consistency between the generated routes and the rendered
documentation, and fixes an issue where custom heading IDs (`{#id}`)
were ignored during route generation.
Fixes angular#67200
33394a0 to
e824be2
Compare
JeanMeche
approved these changes
Feb 23, 2026
Member
JeanMeche
left a comment
There was a problem hiding this comment.
Thanks for the cleanup Suguru ! Much appreciated 🙂
Contributor
|
This has conflicts with patch. So I've switched it to |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The route generation script (
generate-routes.mts) ignores custom heading IDs ({#id}) and generates routes based on the heading text only. This is inconsistent with the markdown pipeline (heading.mts), which respects custom IDs.Issue Number: #67200
What is the new behavior?
The logic for generating heading IDs has been extracted into a shared utility (
adev/shared-docs/pipeline/shared/heading.mts). Bothgenerate-routes.mtsandheading.mtsnow use this shared logic, ensuring consistent behavior. Custom IDs are now correctly respected in generated routes.Does this PR introduce a breaking change?
Other information